Importlib resources #185
Merged
Importlib resources #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -2268,8 +2256,7 @@ | |||
| # add to box | |||
| for i, t in enumerate(qc): | |||
| # File f is never actually used? RM 2022/02/17 | |||
| f = resource_filename(Requirement.parse( # noqa F841 | |||
| "molSimplify"), "molSimplify/icons/geoms/" + t + ".png") | |||
| f = str(resource_files("molSimplify").joinpath(f"icons/geoms/{t}.png")) # noqa F841 | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 27.84% 27.83% -0.01%
==========================================
Files 95 95
Lines 31180 31176 -4
==========================================
- Hits 8681 8679 -2
+ Misses 22499 22497 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch pkg_resources to importlib_resources and the pytest framework to pytest-resource-path